From 5730fa08ad8ae3e6b5a021cf6b208f42f08db3e8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Thu, 21 Aug 2025 01:58:52 +0200 Subject: [PATCH] refactor: improve stats utils input guards MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- src/utils/StatisticUtils.ts | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/utils/StatisticUtils.ts b/src/utils/StatisticUtils.ts index 7ade29c1..75966064 100644 --- a/src/utils/StatisticUtils.ts +++ b/src/utils/StatisticUtils.ts @@ -1,18 +1,18 @@ export const average = (dataSet: number[]): number => { - if (Array.isArray(dataSet) && dataSet.length === 0) { + if (!Array.isArray(dataSet) || dataSet.length === 0) { return 0 } - if (Array.isArray(dataSet) && dataSet.length === 1) { + if (dataSet.length === 1) { return dataSet[0] } return dataSet.reduce((accumulator, number) => accumulator + number, 0) / dataSet.length } export const median = (dataSet: number[]): number => { - if (Array.isArray(dataSet) && dataSet.length === 0) { + if (!Array.isArray(dataSet) || dataSet.length === 0) { return 0 } - if (Array.isArray(dataSet) && dataSet.length === 1) { + if (dataSet.length === 1) { return dataSet[0] } const sortedDataSet = dataSet.slice().sort((a, b) => a - b) @@ -29,10 +29,13 @@ export const max = (...args: number[]): number => // TODO: use order statistics tree https://en.wikipedia.org/wiki/Order_statistic_tree export const percentile = (dataSet: number[], percentile: number): number => { + if (!Array.isArray(dataSet)) { + throw new TypeError('Data set must be an array') + } if (percentile < 0 || percentile > 100) { throw new RangeError('Percentile is not between 0 and 100') } - if (Array.isArray(dataSet) && dataSet.length === 0) { + if (dataSet.length === 0) { return 0 } const sortedDataSet = dataSet.slice().sort((a, b) => a - b) @@ -63,7 +66,10 @@ export const percentile = (dataSet: number[], percentile: number): number => { * @internal */ export const std = (dataSet: number[], dataSetAverage: number = average(dataSet)): number => { - if (Array.isArray(dataSet) && dataSet.length <= 1) { + if (!Array.isArray(dataSet)) { + throw new TypeError('Data set must be an array') + } + if (dataSet.length <= 1) { return 0 } return Math.sqrt( -- 2.43.0