From 68e1a8435e90dba33fa4425b927becf5fbf33d71 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Tue, 7 Oct 2025 14:35:56 +0200 Subject: [PATCH] chore: improve github copilot intructions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .github/copilot-instructions.md | 52 ++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index fb3cf97c..0d23b108 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -7,6 +7,31 @@ These instructions guide GitHub Copilot to generate changes consistent with this - **Tunables**: user-adjustable parameters that shape behavior, exposed via options or configuration files. - **Canonical defaults**: the single, authoritative definition of all tunables and their defaults. +## Implementation guidance for Copilot + +- **Before coding**: + - Perform a comprehensive inventory of the codebase. Search for and read: + - README.md, CONTRIBUTING.md, and all other documentation files. + - relevant code files related to the task. + - Identify existing code architecture, design patterns, canonical defaults, naming patterns and coding styles. +- **When coding**: + - Follow the core principles, TypeScript/Node.js and OCPP-specific conventions below. + - Follow identified design patterns, naming patterns and coding styles. + - Write minimal, verifiable changes that preserve existing behavior when possible. +- **After coding**: + - Ensure changes pass quality gates below. +- **When adding a tunable**: + - Add to canonical defaults with safe value. + - Ensure options and configuration section below is respected. + - Update documentation and serialization. +- **When implementing analytical methods**: + - Follow statistical conventions below. +- **When refactoring**: + - Keep APIs stable; provide aliases if renaming. + - Update code, tests, and documentations atomically. +- **When documenting**: + - Follow documentation conventions below. + ## Core principles - **Design patterns**: prefer established patterns (e.g., factory, singleton, strategy) for code organization and extensibility. @@ -74,34 +99,13 @@ Documentation serves as an operational specification, not narrative prose. - **UUID tracking**: Use UUIDs to correlate requests with responses; store pending operations in Maps with UUID keys. - **Response handling**: Wait for all expected responses before resolving broadcast requests. -## Implementation guidance for Copilot - -- **Before coding**: - - Locate and analyze thoroughly existing relevant code. - - Identify existing code architecture, design patterns, canonical defaults, naming patterns and coding styles. -- **When coding**: - - Follow identified design patterns, naming patterns and coding styles. - - Prioritize algorithmic efficiency. - - Write minimal, verifiable changes that preserve existing behavior when possible. - - Follow TypeScript/Node.js and OCPP-specific conventions above. -- **When adding a tunable**: - - Add to canonical defaults with safe value. - - Update documentation and serialization. -- **When implementing analytical methods**: - - Follow statistical conventions above. -- **When refactoring**: - - Keep APIs stable; provide aliases if renaming. - - Update code, tests, and documentations atomically. -- **When documenting**: - - Follow documentation conventions above. - ## Quality gates -- Build/lint/type checks pass (where applicable). -- Tests pass (where applicable). +- Documented build/lint/type checks pass (where applicable). +- Documented tests pass (where applicable). - Documentation updated to reflect changes. - Logs use appropriate levels (error, warn, info, debug). -- PR title and commit messages follow [Conventional Commits](https://www.conventionalcommits.org/) format. +- Pull request title and commit messages follow [Conventional Commits](https://www.conventionalcommits.org/) format. ## Examples -- 2.43.0