From 6c11eda010248c73502901fcdfa835c9e5f0a9af Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Fri, 7 Feb 2025 12:04:38 +0100 Subject: [PATCH] refactor(qav3): remove uneeded boudaries check in objective function MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py | 2 -- .../user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py | 2 -- 2 files changed, 4 deletions(-) diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index 7f4136b..387a687 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -280,8 +280,6 @@ def objective( min_label_period_candles = int(fit_live_predictions_candles / 10) max_label_period_candles = int(fit_live_predictions_candles / 2) - if max_label_period_candles < min_label_period_candles: - max_label_period_candles = min_label_period_candles label_period_candles = trial.suggest_int( "label_period_candles", min_label_period_candles, diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index 5f37651..cdd148c 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -285,8 +285,6 @@ def objective( min_label_period_candles = int(fit_live_predictions_candles / 10) max_label_period_candles = int(fit_live_predictions_candles / 2) - if max_label_period_candles < min_label_period_candles: - max_label_period_candles = min_label_period_candles label_period_candles = trial.suggest_int( "label_period_candles", min_label_period_candles, max_label_period_candles ) -- 2.43.0