From 752a13201cd4f8552e55fb2abfae412315cbd41f Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@piment-noir.org>
Date: Thu, 22 May 2025 17:27:53 +0200
Subject: [PATCH] refactor(qav3): cleanup pivots detection code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---
 .../freqaimodels/QuickAdapterRegressorV3.py    | 18 ++++++++----------
 quickadapter/user_data/strategies/Utils.py     | 16 +++++++---------
 2 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
index 2d50c6c..c399baa 100644
--- a/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
+++ b/quickadapter/user_data/freqaimodels/QuickAdapterRegressorV3.py
@@ -743,7 +743,7 @@ def train_objective(
     candles_step: int,
     model_training_parameters: dict,
 ) -> float:
-    min_train_window: int = fit_live_predictions_candles * int(1 / test_size)
+    min_train_window: int = fit_live_predictions_candles * int((1 / test_size - 1))
     max_train_window: int = len(X)
     if max_train_window < min_train_window:
         min_train_window = max_train_window
@@ -876,7 +876,6 @@ def zigzag(
     natr_period: int = 14,
     natr_ratio: float = 6.0,
     confirmation_window: int = 3,
-    initial_depth: int = 12,
 ) -> tuple[list[int], list[float], list[int]]:
     n = len(df)
     if df.empty or n < max(natr_period, 2 * confirmation_window + 1):
@@ -898,9 +897,9 @@ def zigzag(
     lows = df["low"].values
 
     state: TrendDirection = TrendDirection.NEUTRAL
-    depth = initial_depth
+    depth = -1
 
-    last_pivot_pos = -depth - 1
+    last_pivot_pos = -1
     pivots_indices, pivots_values, pivots_directions = [], [], []
 
     candidate_pivot_pos = -1
@@ -914,15 +913,14 @@ def zigzag(
     ) -> float:
         start = max(0, pos - natr_period)
         end = min(pos + 1, n)
-        median_factor = np.median([min_factor, max_factor])
         if start >= end:
-            return median_factor
+            return np.median([min_factor, max_factor])
 
         natr_values = get_natr_values(natr_period)
         lookback_natr_values = natr_values[start:end]
         quantile = calculate_quantile(lookback_natr_values, natr_values[pos])
         if np.isnan(quantile):
-            return median_factor
+            return np.median([min_factor, max_factor])
 
         return max_factor - (max_factor - min_factor) * quantile
 
@@ -932,7 +930,7 @@ def zigzag(
         max_depth: int = 36,
     ) -> int:
         if len(pivots_indices) < 2:
-            return depth
+            return min_depth
 
         previous_periods = np.diff(pivots_indices[-3:])
         weights = np.linspace(0.5, 1.5, len(previous_periods))
@@ -950,13 +948,13 @@ def zigzag(
         start = max(0, pos - natr_period)
         end = min(pos + 1, n)
         if start >= end:
-            return min_strength
+            return np.median([min_strength, max_strength])
 
         natr_values = get_natr_values(natr_period)
         lookback_natr_values = natr_values[start:end]
         quantile = calculate_quantile(lookback_natr_values, natr_values[pos])
         if np.isnan(quantile):
-            return min_strength
+            return np.median([min_strength, max_strength])
 
         return min_strength + (max_strength - min_strength) * quantile
 
diff --git a/quickadapter/user_data/strategies/Utils.py b/quickadapter/user_data/strategies/Utils.py
index 6b7dd02..7f8a596 100644
--- a/quickadapter/user_data/strategies/Utils.py
+++ b/quickadapter/user_data/strategies/Utils.py
@@ -365,7 +365,6 @@ def zigzag(
     natr_period: int = 14,
     natr_ratio: float = 6.0,
     confirmation_window: int = 3,
-    initial_depth: int = 12,
 ) -> tuple[list[int], list[float], list[int]]:
     n = len(df)
     if df.empty or n < max(natr_period, 2 * confirmation_window + 1):
@@ -387,9 +386,9 @@ def zigzag(
     lows = df["low"].values
 
     state: TrendDirection = TrendDirection.NEUTRAL
-    depth = initial_depth
+    depth = -1
 
-    last_pivot_pos = -depth - 1
+    last_pivot_pos = -1
     pivots_indices, pivots_values, pivots_directions = [], [], []
 
     candidate_pivot_pos = -1
@@ -403,15 +402,14 @@ def zigzag(
     ) -> float:
         start = max(0, pos - natr_period)
         end = min(pos + 1, n)
-        median_factor = np.median([min_factor, max_factor])
         if start >= end:
-            return median_factor
+            return np.median([min_factor, max_factor])
 
         natr_values = get_natr_values(natr_period)
         lookback_natr_values = natr_values[start:end]
         quantile = calculate_quantile(lookback_natr_values, natr_values[pos])
         if np.isnan(quantile):
-            return median_factor
+            return np.median([min_factor, max_factor])
 
         return max_factor - (max_factor - min_factor) * quantile
 
@@ -421,7 +419,7 @@ def zigzag(
         max_depth: int = 36,
     ) -> int:
         if len(pivots_indices) < 2:
-            return depth
+            return min_depth
 
         previous_periods = np.diff(pivots_indices[-3:])
         weights = np.linspace(0.5, 1.5, len(previous_periods))
@@ -439,13 +437,13 @@ def zigzag(
         start = max(0, pos - natr_period)
         end = min(pos + 1, n)
         if start >= end:
-            return min_strength
+            return np.median([min_strength, max_strength])
 
         natr_values = get_natr_values(natr_period)
         lookback_natr_values = natr_values[start:end]
         quantile = calculate_quantile(lookback_natr_values, natr_values[pos])
         if np.isnan(quantile):
-            return min_strength
+            return np.median([min_strength, max_strength])
 
         return min_strength + (max_strength - min_strength) * quantile
 
-- 
2.43.0