From 8ea47589a8f04b7018bd39c230d68de456c27bb0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Wed, 16 Aug 2023 21:01:04 +0200 Subject: [PATCH] refactor: cleanups MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .github/workflows/ci.yml | 2 +- .github/workflows/generate-documentation.yml | 2 +- .github/workflows/npmpublish.yml | 14 +++++++------- README.md | 6 +++--- .../express-hybrid/src/express-worker.ts | 2 +- .../ws-hybrid/src/websocket-server-worker.ts | 2 +- .../ws-worker_threads/src/main.ts | 2 +- 7 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 01419e26..e23bcf55 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,7 +33,7 @@ jobs: with: version: 8 - - name: Setup node ${{ matrix.node }} + - name: Setup Node.js ${{ matrix.node }} uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} diff --git a/.github/workflows/generate-documentation.yml b/.github/workflows/generate-documentation.yml index 52dbdbde..eb0d1779 100644 --- a/.github/workflows/generate-documentation.yml +++ b/.github/workflows/generate-documentation.yml @@ -16,7 +16,7 @@ jobs: with: version: 8 - - name: Setup node + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version: '18.x' diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 17eb40ed..1b682479 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -17,7 +17,7 @@ jobs: with: version: 8 - - name: Setup Node + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version: '18.x' @@ -50,7 +50,7 @@ jobs: with: version: 8 - - name: Setup Node + - name: Setup Node.js uses: actions/setup-node@v3 with: node-version: '18.x' @@ -76,8 +76,8 @@ jobs: env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} - # - name: Publish Beta Release - # if: ${{ contains(steps.package-version.outputs.version, '-beta') == true }} - # run: pnpm publish --no-git-checks --tag beta - # env: - # NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + - name: Publish Beta Release + if: ${{ contains(steps.package-version.outputs.version, '-beta') == true }} + run: pnpm publish --no-git-checks --tag beta + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/README.md b/README.md index 80a082ac..0faebec4 100644 --- a/README.md +++ b/README.md @@ -62,7 +62,7 @@ Please consult our [general guidelines](#general-guidelines). - [Overview](#overview) - [Installation](#installation) - [Usage](#usage) -- [Node versions](#node-versions) +- [Node.js versions](#nodejs-versions) - [API](#api) - [General guidelines](#general-guidelines) - [Worker choice strategies](#worker-choice-strategies) @@ -161,9 +161,9 @@ You can do the same with the classes _ClusterWorker_, _FixedClusterPool_ and _Dy Remember that workers can only send and receive structured-cloneable data. -## Node versions +## Node.js versions -Node versions >= 16.14.x are supported. +Node.js versions >= 16.14.x are supported. ## [API](./docs/api.md) diff --git a/examples/typescript/http-server-pool/express-hybrid/src/express-worker.ts b/examples/typescript/http-server-pool/express-hybrid/src/express-worker.ts index 901c2072..c6174a99 100644 --- a/examples/typescript/http-server-pool/express-hybrid/src/express-worker.ts +++ b/examples/typescript/http-server-pool/express-hybrid/src/express-worker.ts @@ -15,7 +15,7 @@ import { } from './types.js' const emptyFunction = (): void => { - /** Intentional */ + /* Intentional */ } class ExpressWorker extends ClusterWorker< diff --git a/examples/typescript/websocket-server-pool/ws-hybrid/src/websocket-server-worker.ts b/examples/typescript/websocket-server-pool/ws-hybrid/src/websocket-server-worker.ts index 437fae1b..2a2c4502 100644 --- a/examples/typescript/websocket-server-pool/ws-hybrid/src/websocket-server-worker.ts +++ b/examples/typescript/websocket-server-pool/ws-hybrid/src/websocket-server-worker.ts @@ -15,7 +15,7 @@ import { } from './types.js' const emptyFunction = (): void => { - /** Intentional */ + /* Intentional */ } class WebSocketServerWorker extends ClusterWorker< diff --git a/examples/typescript/websocket-server-pool/ws-worker_threads/src/main.ts b/examples/typescript/websocket-server-pool/ws-worker_threads/src/main.ts index 9edb16b0..0c1acba1 100644 --- a/examples/typescript/websocket-server-pool/ws-worker_threads/src/main.ts +++ b/examples/typescript/websocket-server-pool/ws-worker_threads/src/main.ts @@ -10,7 +10,7 @@ const wss = new WebSocketServer({ port }, () => { }) const emptyFunction = (): void => { - /** Intentional */ + /* Intentional */ } wss.on('connection', (ws) => { -- 2.34.1