From 979e4dfd9b951637923505fff1c9775a5e926252 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Wed, 29 Jan 2025 21:41:29 +0100 Subject: [PATCH] perf: remove uneeded dataframe copy MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../user_data/strategies/QuickAdapterV3.py | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/quickadapter/user_data/strategies/QuickAdapterV3.py b/quickadapter/user_data/strategies/QuickAdapterV3.py index 2cb830e..7508fd7 100644 --- a/quickadapter/user_data/strategies/QuickAdapterV3.py +++ b/quickadapter/user_data/strategies/QuickAdapterV3.py @@ -179,7 +179,6 @@ class QuickAdapterV3(IStrategy): (dataframe["vwap_upperband"] - dataframe["vwap_lowerband"]) / dataframe["vwap_middleband"] ) * 100 - dataframe = dataframe.copy() dataframe["%-dist_to_vwap_upperband"] = get_distance( dataframe["close"], dataframe["vwap_upperband"] ) @@ -397,19 +396,17 @@ def chaikin_mf(df, periods=20): # VWAP bands def VWAPB(dataframe, window_size=20, num_of_std=1): - df = dataframe.copy() - df["vwap"] = qtpylib.rolling_vwap(df, window=window_size) - rolling_std = df["vwap"].rolling(window=window_size).std() - df["vwap_low"] = df["vwap"] - (rolling_std * num_of_std) - df["vwap_high"] = df["vwap"] + (rolling_std * num_of_std) - return df["vwap_low"], df["vwap"], df["vwap_high"] + vwap = qtpylib.rolling_vwap(dataframe, window=window_size) + rolling_std = vwap.rolling(window=window_size).std() + vwap_low = vwap - (rolling_std * num_of_std) + vwap_high = vwap + (rolling_std * num_of_std) + return vwap_low, vwap, vwap_high def EWO(dataframe, sma1_length=5, sma2_length=35): - df = dataframe.copy() - sma1 = ta.EMA(df, timeperiod=sma1_length) - sma2 = ta.EMA(df, timeperiod=sma2_length) - smadif = (sma1 - sma2) / df["close"] * 100 + sma1 = ta.EMA(dataframe, timeperiod=sma1_length) + sma2 = ta.EMA(dataframe, timeperiod=sma2_length) + smadif = (sma1 - sma2) / dataframe["close"] * 100 return smadif -- 2.43.0