From a684a43a12f3e3e227bbfd91a0a6ec7fa97718aa Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Fri, 14 Mar 2025 16:09:07 +0100 Subject: [PATCH] refactor(qav3): handle missing identifier properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- ReforceXY/user_data/freqaimodels/ReforceXY.py | 2 +- .../freqaimodels/LightGBMRegressorQuickAdapterV35.py | 4 ++-- .../user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py index 7fc04ec..e381af9 100644 --- a/ReforceXY/user_data/freqaimodels/ReforceXY.py +++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py @@ -502,7 +502,7 @@ class ReforceXY(BaseReinforcementLearningModel): Runs hyperparameter optimization using Optuna and returns the best hyperparameters found merged with the user defined parameters """ - identifier = self.freqai_info.get("identifier") + identifier = self.freqai_info.get("identifier", "no_id_provided") if self.rl_config_optuna.get("per_pair", False): study_name = f"{identifier}-{dk.pair}" storage = self.get_storage(dk.pair) diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index 641a23e..ee1fcf4 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -294,7 +294,7 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): y_test, test_weights, ) -> tuple[dict, float] | tuple[None, None]: - identifier = self.freqai_info.get("identifier") + identifier = self.freqai_info.get("identifier", "no_id_provided") study_namespace = "hp" study_name = f"{identifier}-{study_namespace}-{pair}" storage = self.optuna_storage(pair) @@ -373,7 +373,7 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): test_weights, model_training_parameters, ) -> tuple[dict, float] | tuple[None, None]: - identifier = self.freqai_info.get("identifier") + identifier = self.freqai_info.get("identifier", "no_id_provided") study_namespace = "period" study_name = f"{identifier}-{study_namespace}-{pair}" storage = self.optuna_storage(pair) diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index f616f52..4a3f622 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -297,7 +297,7 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): y_test, test_weights, ) -> tuple[dict, float] | tuple[None, None]: - identifier = self.freqai_info.get("identifier") + identifier = self.freqai_info.get("identifier", "no_id_provided") study_namespace = "hp" study_name = f"{identifier}-{study_namespace}-{pair}" storage = self.optuna_storage(pair) @@ -376,7 +376,7 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): test_weights, model_training_parameters, ) -> tuple[dict, float] | tuple[None, None]: - identifier = self.freqai_info.get("identifier") + identifier = self.freqai_info.get("identifier", "no_id_provided") study_namespace = "period" study_name = f"{identifier}-{study_namespace}-{pair}" storage = self.optuna_storage(pair) -- 2.43.0