From b221407fb3d8e591b8025398ea81a08c9e4b53f5 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@sap.com>
Date: Sun, 18 Feb 2024 19:40:24 +0100
Subject: [PATCH] refactor(ui): refine action forms
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---
 ui/web/src/components/actions/AddChargingStations.vue | 1 +
 ui/web/src/components/actions/SetSupervisionUrl.vue   | 5 +++--
 ui/web/src/components/charging-stations/CSData.vue    | 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/ui/web/src/components/actions/AddChargingStations.vue b/ui/web/src/components/actions/AddChargingStations.vue
index 7a2f8a59..667edb6c 100644
--- a/ui/web/src/components/actions/AddChargingStations.vue
+++ b/ui/web/src/components/actions/AddChargingStations.vue
@@ -2,6 +2,7 @@
   <h2>Action Add Charging Stations</h2>
   <p>Template:</p>
   <select v-if="state.ready" v-model="state.template">
+    <option disabled value="">Please select a template</option>
     <option v-for="template in app?.appContext.config.globalProperties.$templates">
       {{ template }}
     </option>
diff --git a/ui/web/src/components/actions/SetSupervisionUrl.vue b/ui/web/src/components/actions/SetSupervisionUrl.vue
index 0dfc282c..101ac9ef 100644
--- a/ui/web/src/components/actions/SetSupervisionUrl.vue
+++ b/ui/web/src/components/actions/SetSupervisionUrl.vue
@@ -42,7 +42,7 @@ const props = defineProps<{
 }>()
 
 const state = reactive({
-  supervisionUrl: ''
+  supervisionUrl: 'ws://'
 })
 
 const uiClient = getCurrentInstance()?.appContext.config.globalProperties.$uiClient
@@ -50,6 +50,7 @@ const uiClient = getCurrentInstance()?.appContext.config.globalProperties.$uiCli
 
 <style>
 #supervision-url {
-  text-align: center;
+  width: 90%;
+  text-align: left;
 }
 </style>
diff --git a/ui/web/src/components/charging-stations/CSData.vue b/ui/web/src/components/charging-stations/CSData.vue
index b8fb0662..94b7ae8d 100644
--- a/ui/web/src/components/charging-stations/CSData.vue
+++ b/ui/web/src/components/charging-stations/CSData.vue
@@ -52,7 +52,7 @@
         <tbody id="connectors-table__body">
           <!-- eslint-disable-next-line vue/valid-v-for -->
           <CSConnector
-            v-for="(connector, index) in getConnectors()"
+            v-for="(connector, index) in getConnectorStatuses()"
             :hash-id="props.chargingStation.stationInfo.hashId"
             :charging-station-id="props.chargingStation.stationInfo.chargingStationId"
             :connector-id="index + 1"
@@ -76,7 +76,7 @@ const props = defineProps<{
   chargingStation: ChargingStationData
 }>()
 
-const getConnectors = (): ConnectorStatus[] => {
+const getConnectorStatuses = (): ConnectorStatus[] => {
   if (Array.isArray(props.chargingStation.evses) && props.chargingStation.evses.length > 0) {
     const connectorsStatus: ConnectorStatus[] = []
     for (const [evseId, evseStatus] of props.chargingStation.evses.entries()) {
-- 
2.34.1