From bb337302ccb2a052f68fd2a326f773e8a3656a87 Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@piment-noir.org>
Date: Thu, 24 Sep 2026 00:10:57 +0200
Subject: [PATCH] refactor(ci): consolidate strategy QA jobs

---
 .github/workflows/quality.yml | 30 +++++++-----------------------
 README.md                     |  3 +++
 2 files changed, 10 insertions(+), 23 deletions(-)

diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml
index 81f5fe1..1f6fdef 100644
--- a/.github/workflows/quality.yml
+++ b/.github/workflows/quality.yml
@@ -31,8 +31,8 @@ jobs:
       - name: Check repository formatting
         run: uvx ruff@latest format --check .
 
-  type-check:
-    name: BasedPyright (${{ matrix.name }})
+  strategy-qa:
+    name: QA (${{ matrix.name }})
     runs-on: ubuntu-latest
     timeout-minutes: 30
     strategy:
@@ -63,39 +63,23 @@ jobs:
             "${{ matrix.image }}" \
             /workspace/scripts/check_basedpyright.py \
             --project "${{ matrix.project }}"
-      - name: QuickAdapter runtime regressions
-        if: matrix.project == 'quickadapter'
+      - name: Run runtime regressions
         run: |
           docker run --rm \
             --mount "type=bind,src=${GITHUB_WORKSPACE},dst=/workspace,readonly" \
             --workdir /workspace \
-            --env PYTHONPATH=/workspace/quickadapter/user_data/strategies \
+            --env PYTHONPATH=/workspace/${{ matrix.context }}/user_data/strategies \
             --entrypoint python \
             "${{ matrix.image }}" \
-            -m unittest discover -s quickadapter/tests -v
+            -m unittest discover -s "${{ matrix.context }}/tests" -v
 
-  reforcexy-tests:
-    name: ReforceXY tests
+  reward-space-analysis:
+    name: Reward space analysis
     runs-on: ubuntu-latest
     timeout-minutes: 30
-    env:
-      REFORCEXY_QA_IMAGE: freqai-strategies-reforcexy-qa:ci
     steps:
       - name: Check out repository
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
-      - name: Build QA image
-        run: >-
-          docker build --pull --target qa
-          --tag "${REFORCEXY_QA_IMAGE}"
-          ReforceXY
-      - name: Run runtime regressions
-        run: |
-          docker run --rm \
-            --mount "type=bind,src=${GITHUB_WORKSPACE},dst=/workspace,readonly" \
-            --workdir /workspace \
-            --entrypoint python \
-            "${REFORCEXY_QA_IMAGE}" \
-            -m unittest discover -s ReforceXY/tests -v
       - name: Set up uv
         uses: astral-sh/setup-uv@c18668ad3cf93ea998bef934396af7bb5c839dc7 # v10.2.0
         with:
diff --git a/README.md b/README.md
index 96b324c..1daffd1 100644
--- a/README.md
+++ b/README.md
@@ -481,6 +481,9 @@ PYTHONPATH=/workspace/quickadapter/user_data/strategies \
   python -m unittest discover -s quickadapter/tests -v
 ```
 
+CI runs type checks and runtime regressions in one QA matrix entry per strategy.
+The reward-space analysis suite runs separately with `uv`, without a Freqtrade image.
+
 ### Quality checks
 
 Run repository quality checks from the repository root:
-- 
2.53.0