From cdef2f76a5cf8fc6f90f94d4e36de8fcbe0c5c9d Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@sap.com>
Date: Mon, 8 May 2023 22:45:36 +0200
Subject: [PATCH] fix: fix median computation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
---
 src/utils.ts        | 8 ++------
 tests/utils.test.js | 2 +-
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/utils.ts b/src/utils.ts
index ed118da6..e56c058e 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -25,12 +25,8 @@ export const median = (dataSet: number[]): number => {
   if (Array.isArray(dataSet) && dataSet.length === 1) {
     return dataSet[0]
   }
-  const sortedDataSet = dataSet.slice().sort((a, b) => a - b)
-  const middleIndex = Math.floor(sortedDataSet.length / 2)
-  if (sortedDataSet.length % 2 === 0) {
-    return sortedDataSet[middleIndex]
-  }
-  return (sortedDataSet[middleIndex - 1] + sortedDataSet[middleIndex]) / 2
+  dataSet = [...dataSet].slice().sort((a, b) => a - b)
+  return (dataSet[(dataSet.length - 1) >> 1] + dataSet[dataSet.length >> 1]) / 2
 }
 
 export const isPlainObject = (obj: unknown): boolean =>
diff --git a/tests/utils.test.js b/tests/utils.test.js
index 7d4040ce..c08efbc1 100644
--- a/tests/utils.test.js
+++ b/tests/utils.test.js
@@ -4,7 +4,7 @@ const { isPlainObject, median } = require('../lib/utils')
 describe('Utils test suite', () => {
   it('Verify median computation', () => {
     const array = [0.25, 4.75, 3.05, 6.04, 1.01, 2.02, 5.03]
-    expect(median(array)).toBe(2.535)
+    expect(median(array)).toBe(3.05)
   })
 
   it('Verify isPlainObject() behavior', () => {
-- 
2.34.1