From d03d40d45c9c1a584dc7bc3107b20c7184a02df4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Fri, 3 Oct 2025 12:34:05 +0200 Subject: [PATCH] refactor(reforcexy): cleanup optuna study best trial test MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- ReforceXY/user_data/freqaimodels/ReforceXY.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ReforceXY/user_data/freqaimodels/ReforceXY.py b/ReforceXY/user_data/freqaimodels/ReforceXY.py index bcc1fc7..246c8be 100644 --- a/ReforceXY/user_data/freqaimodels/ReforceXY.py +++ b/ReforceXY/user_data/freqaimodels/ReforceXY.py @@ -967,7 +967,8 @@ class ReforceXY(BaseReinforcementLearningModel): ) hyperopt_failed = True time_spent = time.time() - start_time - if not ReforceXY.study_has_best_trial(study): + study_has_best_trial = ReforceXY.study_has_best_trial(study) + if not study_has_best_trial: logger.error( f"Hyperopt {study_name} failed ({time_spent:.2f} secs): no study best trial found" ) @@ -990,7 +991,7 @@ class ReforceXY(BaseReinforcementLearningModel): study_name, time_spent, ) - if ReforceXY.study_has_best_trial(study): + if study_has_best_trial: logger.info( "Best trial: %s. Score: %s", study.best_trial.number, -- 2.43.0