From d5e7715416d850bf944bb23c6fe7e74b1c952fac Mon Sep 17 00:00:00 2001
From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= <jerome.benoit@piment-noir.org>
Date: Mon, 7 Jul 2025 20:57:22 +0200
Subject: [PATCH] refactor: improve messaging worker id check error message
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
---
 src/pools/abstract-pool.ts    | 6 ++++--
 src/worker/abstract-worker.ts | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/pools/abstract-pool.ts b/src/pools/abstract-pool.ts
index 3f146f8ae..43b1a1d60 100644
--- a/src/pools/abstract-pool.ts
+++ b/src/pools/abstract-pool.ts
@@ -1469,11 +1469,13 @@ export abstract class AbstractPool<
    */
   private checkMessageWorkerId (message: MessageValue<Data | Response>): void {
     if (message.workerId == null) {
-      throw new Error('Worker message received without worker id')
+      throw new Error(
+        `Worker message '${JSON.stringify(message)}' received without worker id`
+      )
     }
     if (this.getWorkerNodeKeyByWorkerId(message.workerId) === -1) {
       throw new Error(
-        `Worker message received from unknown worker '${message.workerId.toString()}'`
+        `Worker message '${JSON.stringify(message)}' received from unknown worker ${message.workerId.toString()}`
       )
     }
   }
diff --git a/src/worker/abstract-worker.ts b/src/worker/abstract-worker.ts
index 49536b0b7..084062d2b 100644
--- a/src/worker/abstract-worker.ts
+++ b/src/worker/abstract-worker.ts
@@ -582,11 +582,13 @@ export abstract class AbstractWorker<
    */
   private checkMessageWorkerId (message: MessageValue<Data>): void {
     if (message.workerId == null) {
-      throw new Error('Message worker id is not set')
+      throw new Error(
+        `Message worker id is not set: ${JSON.stringify(message)}`
+      )
     }
     if (message.workerId !== this.id) {
       throw new Error(
-        `Message worker id ${message.workerId.toString()} does not match the worker id ${this.id.toString()}`
+        `Message worker id ${message.workerId.toString()} does not match the worker id ${this.id.toString()}: ${JSON.stringify(message)}`
       )
     }
   }
-- 
2.43.0