From dbde74d20c745d775800b818a0c18728a27ec945 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Sat, 15 Feb 2025 14:37:20 +0100 Subject: [PATCH] fix(qav3): return only optimized params at HPO MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../freqaimodels/LightGBMRegressorQuickAdapterV35.py | 4 ++-- .../user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index 1ca8453..45c169e 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -309,9 +309,9 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): logger.error(f"Optuna hp hyperopt failed: {e}", exc_info=True) return None - params = {"rmse": study.best_value, **study.best_params} + params = study.best_params # log params - for key, value in params.items(): + for key, value in {"rmse": study.best_value, **params}.items(): logger.info(f"Optuna hp hyperopt | {key:>20s} : {value}") return params diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index 27e4e48..189f0b8 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -310,9 +310,9 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): logger.error(f"Optuna hp hyperopt failed: {e}", exc_info=True) return None - params = {"rmse": study.best_value, **study.best_params} + params = study.best_params # log params - for key, value in params.items(): + for key, value in {"rmse": study.best_value, **params}.items(): logger.info(f"Optuna hp hyperopt | {key:>20s} : {value}") return params -- 2.43.0