From f21427bb673b9af7659e260d0167dca81fd8fd22 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Sat, 15 Feb 2025 22:01:40 +0100 Subject: [PATCH] fix(qav3): refine optuna loaded study validation test MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- .../freqaimodels/LightGBMRegressorQuickAdapterV35.py | 10 ++-------- .../freqaimodels/XGBoostRegressorQuickAdapterV35.py | 10 ++-------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py index 8820b80..04152a8 100644 --- a/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/LightGBMRegressorQuickAdapterV35.py @@ -394,14 +394,8 @@ class LightGBMRegressorQuickAdapterV35(BaseRegressionModel): if not study: return False try: - # Check if there are completed trials - if len(study.trials) == 0: - return False - - # Check if best_params exists (raises ValueError if no trials succeeded) - _ = study.best_params - return True - except ValueError: + _ = study.trials + except KeyError: return False diff --git a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py index fa3fedf..0872136 100644 --- a/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py +++ b/quickadapter/user_data/freqaimodels/XGBoostRegressorQuickAdapterV35.py @@ -395,14 +395,8 @@ class XGBoostRegressorQuickAdapterV35(BaseRegressionModel): if not study: return False try: - # Check if there are completed trials - if len(study.trials) == 0: - return False - - # Check if best_params exists (raises ValueError if no trials succeeded) - _ = study.best_params - return True - except ValueError: + _ = study.trials + except KeyError: return False -- 2.43.0