From f45a8925025d4b76849ea359542bb6bafd39695d Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=B4me=20Benoit?= Date: Sat, 25 May 2024 21:39:15 +0200 Subject: [PATCH 1/1] refactor: refine circular buffer error message MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérôme Benoit --- src/circular-buffer.ts | 2 +- src/fixed-priority-queue.ts | 2 +- tests/circular-buffer.test.mjs | 6 +++--- tests/fixed-priority-queue.test.mjs | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/circular-buffer.ts b/src/circular-buffer.ts index 55f5f9bf..7abb982e 100644 --- a/src/circular-buffer.ts +++ b/src/circular-buffer.ts @@ -87,7 +87,7 @@ export class CircularBuffer { private checkSize (size: number): void { if (!Number.isSafeInteger(size)) { throw new TypeError( - `Invalid circular buffer size: ${size} is not an integer` + `Invalid circular buffer size: '${size}' is not an integer` ) } if (size < 0) { diff --git a/src/fixed-priority-queue.ts b/src/fixed-priority-queue.ts index 075986e2..fadaee75 100644 --- a/src/fixed-priority-queue.ts +++ b/src/fixed-priority-queue.ts @@ -130,7 +130,7 @@ export class FixedPriorityQueue { private checkSize (size: number): void { if (!Number.isSafeInteger(size)) { throw new TypeError( - `Invalid fixed priority queue size: ${size} is not an integer` + `Invalid fixed priority queue size: '${size}' is not an integer` ) } if (size < 0) { diff --git a/tests/circular-buffer.test.mjs b/tests/circular-buffer.test.mjs index 2d275237..f6afdda9 100644 --- a/tests/circular-buffer.test.mjs +++ b/tests/circular-buffer.test.mjs @@ -24,16 +24,16 @@ describe('Circular buffer test suite', t => { it('Verify that circular buffer size is valid at instance creation', () => { expect(() => new CircularBuffer(0.25)).toThrow( - new TypeError('Invalid circular buffer size: 0.25 is not an integer') + new TypeError("Invalid circular buffer size: '0.25' is not an integer") ) expect(() => new CircularBuffer(-1)).toThrow( new RangeError('Invalid circular buffer size: -1 < 0') ) expect(() => new CircularBuffer(Number.MAX_SAFE_INTEGER + 1)).toThrow( new TypeError( - `Invalid circular buffer size: ${ + `Invalid circular buffer size: '${ Number.MAX_SAFE_INTEGER + 1 - } is not an integer` + }' is not an integer` ) ) }) diff --git a/tests/fixed-priority-queue.test.mjs b/tests/fixed-priority-queue.test.mjs index 7f8e380f..7a150690 100644 --- a/tests/fixed-priority-queue.test.mjs +++ b/tests/fixed-priority-queue.test.mjs @@ -8,7 +8,7 @@ // describe('Fixed priority queue test suite', () => { // it('Verify constructor() behavior', () => { // expect(() => new FixedPriorityQueue('')).toThrow( -// new TypeError('Invalid fixed priority queue size: is not an integer') +// new TypeError('Invalid fixed priority queue size: '' is not an integer') // ) // expect(() => new FixedPriorityQueue(-1)).toThrow( // new RangeError('Invalid fixed priority queue size: -1 < 0') -- 2.34.1