[fix] - fix allocation of if list for osx

[deb_libnfs.git] / lib / libnfs-sync.c

diff --git a/lib/libnfs-sync.c b/lib/libnfs-sync.c
index 4dd224c5cdaaf68f301105271a40f12cc1e163dc..0a57c7b97e562c1844fd0b183271d1ff8fea2b7f 100644 (file)
--- a/lib/libnfs-sync.c
+++ b/lib/libnfs-sync.c
@@ -18,6 +18,7 @@
  * High level api to nfs filesystems
  */
 
+#include "config.h"
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -1206,8 +1207,9 @@ struct nfs_server_list *nfs_find_local_servers(void)
        struct nfs_list_data data = {0, NULL};
        struct timeval tv_start, tv_current;
        struct ifconf ifc;
-       int i, size;
+       int size;
        struct pollfd pfd;
+       char *ptr;
 
        rpc = rpc_init_udp_context();
        if (rpc == NULL) {
@@ -1225,12 +1227,13 @@ struct nfs_server_list *nfs_find_local_servers(void)
        ifc.ifc_buf = NULL;
        ifc.ifc_len = size;
 
-       while (ifc.ifc_len == size) {
+       while(ifc.ifc_len > (size - sizeof(struct ifreq))) {
                size *= 2;
 
                free(ifc.ifc_buf);      
                ifc.ifc_len = size;
                ifc.ifc_buf = malloc(size);
+               memset(ifc.ifc_buf, 0, size);
                if (ioctl(rpc_get_fd(rpc), SIOCGIFCONF, (caddr_t)&ifc) < 0) {
                        rpc_destroy_context(rpc);
                        free(ifc.ifc_buf);      
@@ -1238,30 +1241,42 @@ struct nfs_server_list *nfs_find_local_servers(void)
                }
        }       
 
-       for (i = 0; (unsigned)i < ifc.ifc_len / sizeof(struct ifconf); i++) {
+       for (ptr =(char *)ifc.ifc_buf; ptr < ((char *)ifc.ifc_buf) + ifc.ifc_len; ) {
+               struct ifreq *ifr;
                char bcdd[16];
 
-               if (ifc.ifc_req[i].ifr_addr.sa_family != AF_INET) {
+               ifr = (struct ifreq *)ptr;
+#ifdef HAVE_SOCKADDR_LEN
+               if (ifr->ifr_addr.sa_len > sizeof(struct sockaddr)) {
+                       ptr += sizeof(ifr->ifr_name) + ifr->ifr_addr.sa_len;
+               } else {
+                       ptr += sizeof(ifr->ifr_name) + sizeof(struct sockaddr);
+               }
+#else
+               ptr += sizeof(struct ifreq);
+#endif
+
+               if (ifr->ifr_addr.sa_family != AF_INET) {
                        continue;
                }
-               if (ioctl(rpc_get_fd(rpc), SIOCGIFFLAGS, &ifc.ifc_req[i]) < 0) {
+               if (ioctl(rpc_get_fd(rpc), SIOCGIFFLAGS, ifr) < 0) {
                        rpc_destroy_context(rpc);
                        free(ifc.ifc_buf);      
                        return NULL;
                }
-               if (!(ifc.ifc_req[i].ifr_flags & IFF_UP)) {
+               if (!(ifr->ifr_flags & IFF_UP)) {
                        continue;
                }
-               if (ifc.ifc_req[i].ifr_flags & IFF_LOOPBACK) {
+               if (ifr->ifr_flags & IFF_LOOPBACK) {
                        continue;
                }
-               if (!(ifc.ifc_req[i].ifr_flags & IFF_BROADCAST)) {
+               if (!(ifr->ifr_flags & IFF_BROADCAST)) {
                        continue;
                }
-               if (ioctl(rpc_get_fd(rpc), SIOCGIFBRDADDR, &ifc.ifc_req[i]) < 0) {
+               if (ioctl(rpc_get_fd(rpc), SIOCGIFBRDADDR, ifr) < 0) {
                        continue;
                }
-               if (getnameinfo(&ifc.ifc_req[i].ifr_broadaddr, sizeof(struct sockaddr_in), &bcdd[0], sizeof(bcdd), NULL, 0, NI_NUMERICHOST) < 0) {
+               if (getnameinfo(&ifr->ifr_broadaddr, sizeof(struct sockaddr_in), &bcdd[0], sizeof(bcdd), NULL, 0, NI_NUMERICHOST) < 0) {
                        continue;
                }
                if (rpc_set_udp_destination(rpc, bcdd, 111, 1) < 0) {