Simplify the code.

[Project_proches_de_moi-server.git] / src / Controller / PersonController.php

diff --git a/src/Controller/PersonController.php b/src/Controller/PersonController.php
index 18f4a3ed7777e36c454a9b8d370058e1f4554c7b..d4bd7ff374204dc15b14c68f3ec21e7f6d096bd3 100644 (file)
--- a/src/Controller/PersonController.php
+++ b/src/Controller/PersonController.php
@@ -16,7 +16,7 @@ class PersonController extends Controller
 {
     /**
      * @Rest\Post(
-     *     path = "/api/person/inscription",
+     *     path = "/person/inscription",
      *     name = "create_person"
      * )
      * @Rest\View(StatusCode = Response::HTTP_CREATED)
@@ -61,7 +61,7 @@ class PersonController extends Controller
         $person = $em->getRepository('App:Person')->find($request->get('id'));
 
         if (empty($person)) {
-            return View::create(['message' => 'Person not found'], Response::HTTP_NOT_FOUND);
+            return $this->PersonNotFound();
         }
 
         $person->setFirstName($request->get('firstname'));
@@ -82,6 +82,21 @@ class PersonController extends Controller
 
     }
 
+    /**
+     * @Rest\Get("/api/person/{id}/localisations")
+     */
+    public function getLocalisationsAction(Request $request)
+    {
+        $em = $this->getDoctrine()->getManager();
+        $localisations = $em->getRepository('App:Localisation')->findBy(['person' => $request->get('id')]);
+
+        if (empty($localisations)) {
+            return $this->PersonLocalisationsNotFound();
+        }
+
+        return $localisations;
+    }
+
     /**
      * @Rest\Post("/api/person/{id}/localisation")
      * @Rest\View(StatusCode = Response::HTTP_CREATED)
@@ -114,13 +129,10 @@ class PersonController extends Controller
         $person = $em->getRepository('App:Person')->find($request->get('id'));
 
         if (empty($person)) {
-            return View::create(['message' => 'Person not found'], Response::HTTP_NOT_FOUND);
+            return $this->PersonNotFound();
         }
 
-        $view = View::create($person);
-        $view->setFormat('json');
-
-        return $view;
+        return $person;
    }
 
    /**
@@ -134,16 +146,13 @@ class PersonController extends Controller
   public function showPersonByEmail(Request $request)
   {
         $em = $this->getDoctrine()->getManager();
-        $person = $em->getRepository('App:Person')->find($request->get('email'));
+        $person = $em->getRepository('App:Person')->findOneBy(['email' => $request->get('email')]);
 
         if (empty($person)) {
-            return View::create(['message' => 'Person not found'], Response::HTTP_NOT_FOUND);
+            return $this->PersonNotFound();
         }
 
-        $view = View::create($person);
-        $view->setFormat('json');
-
-        return $view;
+        return $person;
   }
 
    /**
@@ -160,15 +169,31 @@ class PersonController extends Controller
         $person = $em->getRepository('App:Person')->find($request->get('id'));
 
         if (empty($person)) {
-            return View::create(['message' => 'Person not found'], Response::HTTP_NOT_FOUND);
+            return $this->PersonNotFound();
         }
 
-        $view = View::create($person->getFriends());
-        $view->setFormat('json');
-
-        return $view;
+        return $person->getFriends();
   }
 
+  /**
+  * @Rest\Get(
+  *     path = "/api/persons",
+  *     name = "show_persons"
+  * )
+  * @Rest\View()
+  */
+ public function showPersons(Request $request)
+ {
+       $em = $this->getDoctrine()->getManager();
+       $persons = $em->getRepository('App:Person')->findAll();
+
+       if (empty($persons)) {
+           return $this->PersonNotFound();
+       }
+
+       return $persons;
+ }
+
   /**
   * @Rest\Get(
   *     path = "/api/person/{email}/friends",
@@ -180,15 +205,21 @@ class PersonController extends Controller
  public function showPersonFriendsByEmail(Request $request)
  {
         $em = $this->getDoctrine()->getManager();
-        $person = $em->getRepository('App:Person')->find($request->get('email'));
+        $person = $em->getRepository('App:Person')->findOneBy(['email' => $request->get('email')]);
 
         if (empty($person)) {
-            return View::create(['message' => 'Person not found'], Response::HTTP_NOT_FOUND);
+            return $this->PersonNotFound();
         }
 
-        $view = View::create($person->getFriends());
-        $view->setFormat('json');
+        return $person->getFriends();
+ }
+
+ private function PersonNotFound() {
+     return View::create(['message' => 'Person not found'], Response::HTTP_NOT_FOUND);
+ }
 
-        return $view;
+ private function PersonLocalisationsNotFound() {
+     return View::create(['message' => 'Person localisations not found'], Response::HTTP_NOT_FOUND);
  }
+
 }