refactor: code cleanups

Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>

diff --git a/max.mjs b/max.mjs
index 8f1f698a6a8b5f11488444913b70e17b4c11005d..8914520e21c75b7e2ee5d50b41ea80a1f310b142 100644 (file)
--- a/max.mjs
+++ b/max.mjs
@@ -10,11 +10,11 @@ const testArray = generateRandomNumberArray(size)
  * @returns
  */
 function loopMax (values) {
-  let max = -Infinity
+  let maximum = -Infinity
   for (const value of values) {
-    if (value > max) max = value
+    if (value > maximum) maximum = value
   }
-  return max
+  return maximum
 }
 
 /**
@@ -23,7 +23,10 @@ function loopMax (values) {
  * @returns
  */
 function reduceTernaryMax (values) {
-  return values.reduce((a, b) => (a > b ? a : b), -Infinity)
+  return values.reduce(
+    (maximum, num) => (maximum > num ? maximum : num),
+    -Infinity
+  )
 }
 
 /**
@@ -32,7 +35,7 @@ function reduceTernaryMax (values) {
  * @returns
  */
 function reduceMathMax (values) {
-  return values.reduce((a, b) => Math.max(a, b), -Infinity)
+  return values.reduce((maximum, num) => Math.max(maximum, num), -Infinity)
 }
 
 /**

diff --git a/min.mjs b/min.mjs
index 3ea46c4be780e94d0dbf9db1d09b6e4b932cf9eb..2ac02b52bb9b9a0a4972b3a307779a11c4d5e343 100644 (file)
--- a/min.mjs
+++ b/min.mjs
@@ -10,11 +10,11 @@ const testArray = generateRandomNumberArray(size)
  * @returns
  */
 function loopMin (values) {
-  let min = Infinity
+  let minimum = Infinity
   for (const value of values) {
-    if (value < min) min = value
+    if (value < minimum) minimum = value
   }
-  return min
+  return minimum
 }
 
 /**
@@ -23,7 +23,10 @@ function loopMin (values) {
  * @returns
  */
 function reduceTernaryMin (values) {
-  return values.reduce((a, b) => (a < b ? a : b), Infinity)
+  return values.reduce(
+    (minimum, num) => (minimum < num ? minimum : num),
+    Infinity
+  )
 }
 
 /**
@@ -32,7 +35,7 @@ function reduceTernaryMin (values) {
  * @returns
  */
 function reduceMathMin (values) {
-  return values.reduce((a, b) => Math.min(a, b), Infinity)
+  return values.reduce((minimum, num) => Math.min(minimum, num), Infinity)
 }
 
 /**